-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Chrome 121 beta #21603
Updates for Chrome 121 beta #21603
Conversation
Cool! I will spot check the tagged features a little later and if everything looks good create a corresponding And if @captainbrosset wants to comment on creating a new |
Thanks @ddbeck! I called the group |
No that was just me misreading 🤦. I've edited my earlier comment to make it more obvious what the heck I was talking about. |
OK, reviewing only the tagging part here: I've now compared the spec to tagged features. I'm happy with this list. I've opened a companion feature PR on web-features: web-platform-dx/web-features#496. Again, it'd be nice to get someone who knows anything at all about this API to check to see if I've missed anything (or if there's a likely reason to hold this back—e.g., it might not actually land in 121). But I'd be OK without it too. |
Creating a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot checked the EditContext-related stuff and the edit-context
web-features group, and all seems fine to me.
I don't think there's a lot of risks for mistakes here. This is a self-contained API (i.e. not like Clipboard 😉) that shipped all in one release.
That said, I'm also very new to it myself (probably like everyone but the spec authors at this point).
I'll be documenting this on MDN soon, so might have more feedback after that.
@Elchi3 I went through all the Chrome 121 beta entries with a fine toothcomb and compiled the following lists to represent items that the collector picked up, versus ones it didn't. This time I opted for a simplified format that was quicker to compile and possibly a bit easier to go through. Does this work for you? Features listed in Chrome 121 beta releaseFound by the collector
Not found by the collector
|
Thanks once again Chris for your detailed analysis. It will help us to detect more things automatically in the future. ❤️ Some comments on items not found:
Two things that seem like we should have detected them with our current infrastructure:
Yes, I am surprised too. We have #21486 to investigate the situation. Seems like the API was exposed for a long time already and so we feature detected it when it shipped to Android already.
Yes, strange. I wonder if this slipped to 122? See https://wpt.fyi/results/storage/buckets?label=master&product=chrome-121.0.6167.8%20beta&product=chrome%5Bexperimental%5D&aligned where the WPT fail for 121 and pass for 122. Maybe Chromestatus is wrong? |
@chrisdavidmills I'm not planning to add more to this PR. If what this PR changes, looks good to you, I'd appreciate an approval and merge. :) I left some comments for the rest, but that should probably be sorted in other PRs. |
@Elchi3. Sure thing; merging! |
https://chromestatus.com/feature/5041440373604352 says this is supported in Chrome for Android, and wpt.fyi results agree: https://wpt.fyi/results/editing/edit-context?label=master&product=chrome&product=chrome_android This updates all features tagged with web-features:edit-context, originally added here: mdn#21603
https://chromestatus.com/feature/5041440373604352 says this is supported in Chrome for Android, and wpt.fyi results agree: https://wpt.fyi/results/editing/edit-context?label=master&product=chrome&product=chrome_android This updates all features tagged with web-features:edit-context, originally added here: #21603
The Open Web Docs BCD collector found new features shipping in Chrome 121 beta. Currently, the collector covers about 82% of BCD, so the following list might not be exhaustive. Certain APIs that use enrollment etc. might not have been found either. For comparison, the Chromestatus list for Chrome 121 is here: https://chromestatus.com/features#milestone%3D121.
With this PR, BCD marks the following features as shipping in Chrome 121: cc @chrisdavidmills
Some new features have been tagged to be part of the
"web-features:edit-context"
group. cc @ddbeck