-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAssembly features as a new category #20136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions:
- Unlike other top-level categories, the webassembly features are added flat without any folders or categories. Will this scale?
- Are there spec_urls for these features? It says standards_track true, so I guess there must be.
- Are there mdn_urls for these features?
- Will this PR mean a major version bump for BCD given a new top-level tree is added?
When @MendyBerger wrote the PR to add this category into the collector, they used
@MendyBerger, you know a lot more about WebAssembly than we do -- do you know if there are spec URLs associated with these features?
Not yet as far as I know, but I believe there are plans to write them!
Not a major version, but a minor version, since it's adding a new backwards-compatible feature! |
Subfolder: Spec urls: |
Actually, the collector wouldn't deal with spec URLs; we'd want to add them right here in BCD! Would you be down to submit a PR to this branch or send me a patch file so I can apply the appropriate changes? (Alternatively, if you'd like to send a list that maps spec URLs to BCD features, I can add those in too!) |
Thanks for your comments!
|
Got the spec URLs added, and made the appropriate changes to typedefs, the readme and more -- this is now ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let's do this then 👍
This PR adds a brand new category for WebAssembly features -- that is, features within the WebAssembly code itself rather than just the JavaScript API. The results were collected by the mdn-bcd-collector project (v10.0.0).
CC @MendyBerger