Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAssembly features as a new category #20136

Merged
merged 11 commits into from
Jun 26, 2023
Merged

Add WebAssembly features as a new category #20136

merged 11 commits into from
Jun 26, 2023

Conversation

queengooborg
Copy link
Contributor

This PR adds a brand new category for WebAssembly features -- that is, features within the WebAssembly code itself rather than just the JavaScript API. The results were collected by the mdn-bcd-collector project (v10.0.0).

CC @MendyBerger

@github-actions github-actions bot added bulk_update An update to a mass amount of data, or scripts/linters related to such changes infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. scripts Issues or pull requests regarding the scripts in scripts/. labels Jun 16, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions:

  • Unlike other top-level categories, the webassembly features are added flat without any folders or categories. Will this scale?
  • Are there spec_urls for these features? It says standards_track true, so I guess there must be.
  • Are there mdn_urls for these features?
  • Will this PR mean a major version bump for BCD given a new top-level tree is added?

@queengooborg queengooborg added the semver-minor-bump A change that adds a new, non-potentially-breaking feature for consumers label Jun 22, 2023
@queengooborg
Copy link
Contributor Author

  • Unlike other top-level categories, the webassembly features are added flat without any folders or categories. Will this scale?

When @MendyBerger wrote the PR to add this category into the collector, they used webassembly.features.* instead of just webassembly.*, but I later thought a subfolder was redundant. Happy to add it back though!

  • Are there spec_urls for these features? It says standards_track true, so I guess there must be.

@MendyBerger, you know a lot more about WebAssembly than we do -- do you know if there are spec URLs associated with these features?

  • Are there mdn_urls for these features?

Not yet as far as I know, but I believe there are plans to write them!

  • Will this PR mean a major version bump for BCD given a new top-level tree is added?

Not a major version, but a minor version, since it's adding a new backwards-compatible feature!

@MendyBerger
Copy link
Contributor

Subfolder:
I don't expect too many features on the wasm side of things. It's pretty low level, so development of new features are probably going to slow down over time. But I'm not working on the specs so take my opinion with a grain of salt.
I don't think that a subfolder would make a huge difference either way. Whatever works I guess 🤷 .

Spec urls:
There sure are, I can add them in.
I'm assuming they would go in the wasm.json file in collector, right?

@queengooborg
Copy link
Contributor Author

There sure are, I can add them in.
I'm assuming they would go in the wasm.json file in collector, right?

Actually, the collector wouldn't deal with spec URLs; we'd want to add them right here in BCD!

Would you be down to submit a PR to this branch or send me a patch file so I can apply the appropriate changes? (Alternatively, if you'd like to send a list that maps spec URLs to BCD features, I can add those in too!)

@Elchi3
Copy link
Member

Elchi3 commented Jun 23, 2023

Thanks for your comments!

  • no sub folders then
  • minor version bump
  • let's add spec_urls before merging this.

@MendyBerger
Copy link
Contributor

@queengooborg see queengooborg#53

@github-actions github-actions bot added docs Issues or pull requests regarding the documentation of this project. schema Isses or pull requests regarding the JSON schema files used in this project. labels Jun 26, 2023
@queengooborg
Copy link
Contributor Author

Got the spec URLs added, and made the appropriate changes to typedefs, the readme and more -- this is now ready to merge!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's do this then 👍

@Elchi3 Elchi3 merged commit 7cb45a8 into mdn:main Jun 26, 2023
@queengooborg queengooborg deleted the wasm branch June 26, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/. semver-minor-bump A change that adds a new, non-potentially-breaking feature for consumers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants