Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session.storage support for Safari 16.4 #18997

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add session.storage support for Safari 16.4 #18997

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cdc9f5
Added session.storage support for Safari 16.4
jdatapple Feb 23, 2023
31e6d1d
Added Chrome storage quote note; removed Safari note
jdatapple Feb 24, 2023
b7aba6b
Fixed JSON syntax issue
jdatapple Feb 24, 2023
582a0ad
Fixed JSON syntax for Chrome storage.session note
jdatapple Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions webextensions/api/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,8 @@
"mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/storage/session",
"support": {
"chrome": {
"version_added": "102"
"version_added": "102",
"notes": "Before version 112, storage quota limits were 1MB."
},
"edge": "mirror",
"firefox": {
Expand All @@ -372,7 +373,7 @@
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
"version_added": false
"version_added": "16.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Safari support the setAccessLevel method? See https://bugzilla.mozilla.org/show_bug.cgi?id=1724754#c1 and mdn/content#24873

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdatapple are you able to confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari does not support the setAccessLevel method.

},
"safari_ios": "mirror"
}
Expand Down