-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate arguments.callee #18384
Deprecate arguments.callee #18384
Conversation
Is this really deprecated per the guidelines? https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#setting-deprecated I can't find authoritative text suggesting so. If it is, then I guess we want an accompanying content PR? |
I suggest not to manually create a PR for this in The The latest specs (2023) still defines the property on arguments object:
|
@Elchi3 This is deprecated in the sense that it's forbidden in strict mode. Because ES can never unship APIs, this is closest to "removal from spec" in the ES world. I'm not sure what content change is necessary, but (1) it's already listed on the deprecated features page (2) accessing In fact, I do have a content change prepared for the related pages, although it's not totally related to this deprecation, but more for the page types work. The BCD syncing is automatic as Onkar noted, so I think this is all we need. @OnkarRuikar Your quoted spec is the "throwing" part, which is strictly more "deprecated-like" than not installing the property at all. |
I'm double checking here because In case of
It would be nice to have a similar authoritative spec text for this case so that the discouragement position is as strong as that for
Thanks! Even though it is not a non-standard feature I guess this could count as a signal for us to mark it in fact deprecated per this guideline rule:
What do you think? |
If I try hard enough, I can probably find meeting notes from ES5 about how implementers dislike this feature (which is why it's removed from strict mode at all). But sifting through pre-ES6 notes is always a pain, so if you are convinced, we should be good :) After all, developers not being able to use the feature is already a stronger signal than a mere editorial marker of deprecation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'm convinced, let's try this then and see if anyone complains :)
Summary
This thing is not available in strict mode, so it should be deprecated like
with
statements. It's already noted in the JS deprecated features page.Test results and supporting details
Related issues