Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for CSS container query relative length units #18227

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 16, 2022

This PR adds details about container query length units which are behind a pref layout.css.container-queries.enabled.

Tested on other browsers using BrowserStack

Browser Support added
Webkit https://bugs.webkit.org/show_bug.cgi?id=238021
Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1744231

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 16, 2022
@bsmth bsmth self-assigned this Nov 16, 2022
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since Edge and Opera match Chrome's data though, we can just mirror them!

css/types/length.json Outdated Show resolved Hide resolved
css/types/length.json Outdated Show resolved Hide resolved
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
@bsmth
Copy link
Member Author

bsmth commented Nov 21, 2022

since Edge and Opera match Chrome's data though, we can just mirror them!

Very good, tnx! 👍🏻

@bsmth
Copy link
Member Author

bsmth commented Nov 22, 2022

Shall I go ahead and merge @queengooborg?

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes, LGTM!

@queengooborg queengooborg merged commit 113aa3e into mdn:main Nov 22, 2022
@bsmth bsmth deleted the 22119-container-query-length-units branch November 22, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants