Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme API compatibility data #1721

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Update theme API compatibility data #1721

merged 1 commit into from
Apr 6, 2018

Conversation

nt1m
Copy link
Contributor

@nt1m nt1m commented Apr 2, 2018

No description provided.

@nt1m
Copy link
Contributor Author

nt1m commented Apr 2, 2018

@wbamberg Summary of changes:

  • Added new properties in Firefox 61 and 60
  • Changed background_tab_text to tab_background_text (it's tab_background_text in Chrome, and we managed to rename it on time for 59 in Firefox).
  • Reordered alphabetically

@Elchi3 Elchi3 added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Apr 4, 2018
@Elchi3 Elchi3 requested a review from wbamberg April 4, 2018 10:33
@wbamberg
Copy link
Collaborator

wbamberg commented Apr 4, 2018

Thanks @nt1m . Do you have bugzilla references for these changes?

@nt1m
Copy link
Contributor Author

nt1m commented Apr 4, 2018

@wbamberg Firefox 60 bugs

Other changes

wbamberg
wbamberg approved these changes Apr 6, 2018
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to have references for the specific bugs which added/changed these properties, rather than a listing of all theme bugs.

But r+ anyway, the PR looks good as far as I can tell.

@wbamberg wbamberg merged commit f6eb668 into mdn:master Apr 6, 2018
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Aug 10, 2024
@queengooborg
Update Chromium data for webextensions.manifest.theme.colors
2fdcd04 
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `colors` member of the `theme` Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#581, mdn#1721
@queengooborg queengooborg mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nt1m @wbamberg @Elchi3