Tighten irrelevant flag data removal guidelines #16637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
docs
|
Related issue: #16568. |
|
This was a +1 for everyone in the last BCD meeting, so we'll go forward with making flag data irrelevance immediate! |
jugglinmike
added a commit
to bocoup/mdn-bcd-collector-bc-legacy
that referenced
this pull request
Sep 1, 2022
A recent change in the BCD project policy stipulates that information about feature flags should be removed whenever a feature becomes supported by default [1]. Modify the `update-bcd` script to honor the new policy whenever new test results trigger that condition. [1] mdn/browser-compat-data#16637
jugglinmike
added a commit
to bocoup/mdn-bcd-collector-bc-legacy
that referenced
this pull request
Sep 1, 2022
A recent change in the BCD project policy stipulates that information about feature flags should be removed whenever a feature becomes supported by default [1]. Modify the `update-bcd` script to honor the new policy whenever new test results trigger that condition. Include a test for the case where positive test results are added for a feature that is already supported via a prefix. This patch intentionally doesn't change that behavior because prefixes "are part of the web platform that web developers have to deal with." [2] The test is to prevent regressions and emphasize the intention. [1] mdn/browser-compat-data#16637 [2] https://matrix.to/#/!cGYYDEJwjktUBMSTQT:mozilla.org/$JTWeMpzNMULBTZcx-pWFnUNX7DIzE5xPySd70Kpr-MU?via=mozilla.org&via=matrix.org&via=igalia.com),
foolip
pushed a commit
to foolip/mdn-bcd-collector
that referenced
this pull request
Sep 14, 2022
A recent change in the BCD project policy stipulates that information about feature flags should be removed whenever a feature becomes supported by default [1]. Modify the `update-bcd` script to honor the new policy whenever new test results trigger that condition. Include a test for the case where positive test results are added for a feature that is already supported via a prefix. This patch intentionally doesn't change that behavior because prefixes "are part of the web platform that web developers have to deal with." [2] The test is to prevent regressions and emphasize the intention. [1] mdn/browser-compat-data#16637 [2] https://matrix.to/#/!cGYYDEJwjktUBMSTQT:mozilla.org/$JTWeMpzNMULBTZcx-pWFnUNX7DIzE5xPySd70Kpr-MU?via=mozilla.org&via=matrix.org&via=igalia.com),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the irrelevant flag data removal guideline to remove the timeframe for irrelevant flag data removal from two years to immediately. As described in mdn/mdn-community#119 (reply in thread), flag data essentially becomes irrelevant the moment the feature is enabled by default in a stable release.
Fixes #16568.