Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds spec data to MIDI interfaces #11505

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Conversation

rachelandrew
Copy link
Collaborator

Adds spec URLs to the MIDI interfaces as I'm creating the documentation pages.

I also removed a duplicate statechange event from MIDIAccess, as this seemed to be a duplicate of onstatechange.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 13, 2021
@foolip
Copy link
Collaborator

foolip commented Jul 13, 2021

Adds spec URLs to the MIDI interfaces as I'm creating the documentation pages.

Excellent! I can review this.

I also removed a duplicate statechange event from MIDIAccess, as this seemed to be a duplicate of onstatechange.

Unfortunately support of events is a bit of a mess in BCD, with #7545 describing the current state of things with no clear conclusion for how to improve it. We have lots of APIs with both onfoo and foo_event entries, and while I've never asked for foo_event entries to be added, I also don't think we should remove them until that issue has been resolved somehow.

@@ -191,58 +195,10 @@
}
}
},
"statechange_event": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this entry. Unfortunately there's nothing to link to in the spec, the "event itself" (as opposed to the onstatechange property) only shows up as that "statechange" string in step 3 of the algorithm in https://webaudio.github.io/web-midi-api/#dom-midiaccess-onstatechange.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just re-added that.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I found another thing.

api/MIDIInput.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rachelandrew for your patience!

@foolip foolip merged commit 6663c58 into mdn:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants