Part 1 of 2: copy feature policy to permissions policy.#11332
Part 1 of 2: copy feature policy to permissions policy.#11332
Conversation
|
I'm not comfortable with this approach. My major concerns are:
|
|
What lead me to this was the large number of pages that would contain missing BCD and the unknown amount of time needed to correct it. I'm working as quickly as I can to keep that time short, but I expect the review process to be tedious and somewhat drawn out. To help, I've already split the affected pages into 4 separate PRs which I recommend merging in close proximity. The PR to remove the duplicate content would be removed as soon as the updated files are deployed. I would suggest that any changes to this data go exclusively to the replacement key: If you have a better idea, I'm all ears. |
|
I've opened four PRs to replace 'feature policy' with 'permissions policy'. I believe this is all of the content that needs to be updated. |
| { | ||
| "alternative_name": "Feature-Policy", | ||
| "version_added": "60", | ||
| "version_removed": "87" |
There was a problem hiding this comment.
Was support for the Feature-Policy header really removed, one release before its replacement even?
|
Strictly speaking, a spec rename should be accomplished by renaming the feature-policy json to permission policy, updating the content, and adding an alternative name. However I don't think BCD can properly represent the relationship using alternative names because these can't be fully qualified - as a result it might become quite messy to indicate the things that do and do not have an alternative name as the spec evolves. Proposal: We treat
If we treat them as separate implementations then the versioning can be presented very clearly. The only issue we'd have is whether we "try" to present alternative names at all. I'd say "not". @ddbeck FYI |
|
@jpmedley I'm going to close this PR, since the corresponding content PRs have also been closed. Feel free to open a new one with the additions of permissions policy, but let's treat feature policy and permission policy as two closely related but distinct features. Thank you! |
PLEASE READ CAREFULLY. A unique problem requires a unique approach, which is described below.
The rename of 'Feature Policy' to 'Permissions Policy' requires that BCD be moved as well. Regardless of whether BCD is changed before MDN content or vice-versa, there will be a stage where BCD keys in MDN documents will point to data that isn't there. To get around this, I have duplicated the data. In other words, when this is deployed there will be data under the keys
Feature-PolicyandPermissions-Policy. This is by design. When the new MDN pages are deployed, I'll come back remove the data recorded underFeature-Policy.mdn/content#1831