Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text-indent each-line and hanging keywords for Safari TP #10635

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

aburymichael
Copy link
Contributor

Summary

Added TP for Safari as Release 124 resolves each-line and hanging keywords for text-indent property

Test results and supporting details

https://bugs.webkit.org/show_bug.cgi?id=223851

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 25, 2021
@ddbeck ddbeck added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 26, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented May 26, 2021

Like your other PR, this is blocked (by #10334) and will fail CI because we don't yet have a way of tracking Safari TP and similar in-development versions of browsers. We're working on it, but this will be on hold until then.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aburymichael, since #10334 has been merged, we can support Safari TP with the new "preview" value. I've left line comments to demonstrate the change. Thank you for your patience on this!

css/properties/text-indent.json Outdated Show resolved Hide resolved
css/properties/text-indent.json Outdated Show resolved Hide resolved
@ddbeck ddbeck removed the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Aug 18, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck changed the title Update text-indent.json Update text-indent each-line and hanging keywords for Safari TP Aug 19, 2021
@ddbeck ddbeck merged commit c4e1106 into mdn:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants