Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GitHub Actions up to date with GitHub's Dependabot #17

Closed
wants to merge 1 commit into from

Conversation

@mdmintz
Copy link
Owner

mdmintz commented Feb 12, 2024

.github/workflows/python-package.yml has already been updated to use the newer versions.

.github/workflows/python-package-legacy.yml is expected to have those deprecation warnings because Python 3.6 is already deprecated, and we're keeping support for that anyway, at least until GitHub Actions drops support for Python 3.6 entirely.

Definitely no Dependabot, as that creates unnecessary noise for things that are already known.

@mdmintz mdmintz closed this Feb 12, 2024
@cclauss cclauss deleted the patch-1 branch February 12, 2024 15:13
@cclauss
Copy link
Contributor Author

cclauss commented Feb 12, 2024

The Actions updates have nothing to do with the versions of Python that can be used. That is governed not by the actions but by the version of Ubuntu, macOS, or Windows used and the https://github.com/actions/python-versions file.

I agree that Dependabot can be chatty to PyPI or npm, etc. dependencies but Actions do not receive major updates often. Reduction of chattiness was handled in this PR by bundling all Actions updates into a single PR (so max one new PR a week) but the interval could be set to monthly (so max one new PR a month -- not chatty but at least automatic).

@mdmintz
Copy link
Owner

mdmintz commented Feb 12, 2024

The newer Actions versions don't fully support Python 3.6: https://github.com/mdmintz/pynose/actions/runs/4308067130/job/11698879866

See actions/setup-python#544 for more info.

That's the whole reason why the original Actions job got split into two in the first place:

@cclauss
Copy link
Contributor Author

cclauss commented Feb 12, 2024

If you drop back from runs-on: ubuntu-latest to ubuntu-20.04 you will be able to test on Py3.5 and Py3.6 even on the latest action.

@mdmintz
Copy link
Owner

mdmintz commented Feb 12, 2024

I updated to actions/setup-python@v5: 8d612ee
The warning message went away. All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants