-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #29 #92
base: main
Are you sure you want to change the base?
fixed #29 #92
Conversation
…vs populated state)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently dist
folder should only be updated on new releases. Reason being, that the website uses main
as a production branch and automatically updates from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a proper full review later, but from a quick glance (both code and running it) the current changes look good and the code is clean!
added a new file '_md' so make it easier to include all 'md' related variables (state, motion, typo, colors, etc.)
outlined text fields are now working
added examples of disabled textfields to the index page
@robinlahtinen I believe this PR fixes #29. Could you please do a full review whenever you have some spare time ? |
Not sure why the labeler is failing. Might be related to this issue though: actions/labeler#12 |
Good idea! Material Design Light supports dark theme, so that should also be taken in to concern.
Code looks good and seems to be up to the specifications mostly. It is missing support for dark theme and some lesser problems I referenced directly on the code reviews below.
|
@robinlahtinen I've made the changes you requested, splitted the file in two files, one for filled text fields and another one for outlined text fields. Could you please review one more time and merge if its ok? Thx |
This is a WIP. textfield-filled is 90% done. outlined is completely broken
@robinlahtinen : This is the first stab at fixing #29 .
It's currently working on Firefox and Chrome. I believe it should be working with fairly old browsers and the default mode is 'populated' so that old browsers don't supporting fancy css would work.
Note that I changed classnames to be 'textfield-' instwerd of 'fieldtext-' and such.
Whenever you have time I would appreciate any feedback you may have.