DEV: setup pixi #46
DEV: setup pixi #46
Conversation
|
For some context here, https://data-apis.org/array-api-extra/contributing.html#development-workflow is the kind of development workflow this enables (without having to worry about pip or conda at all). The other main benefit is simplifying the CI workflows, and making them easily reproducible locally. |
|
Thanks! I'm happy with trying this if @keewis is. |
That seems to be from one of the pre-commit hooks which @keewis added. |
|
Ah, OK. @keewis is that something you could adjust? |
There was a problem hiding this comment.
I'm happy with trying this if @keewis is.
I have never used pixi (or other workflow managers... as far as I can tell, it is a combination of a package and a workflow manager), but I'm happy to try.
However, that means I'll probably ping you whenever I have issues I can't figure out myself.
Ah, OK. @keewis is that something you could adjust?
quite possibly, but normalizing formats like markdown is kinda the point of the auto-formatter (in this case, prettier). We only see this here because this adds (and applies) all hooks, which we should have done earlier. Otherwise we can split this out into a separate PR and discuss there.
marray/tests/test_marray.py
Outdated
| @@ -310,10 +310,10 @@ def test_indexing(xp): | |||
| # `__setitem__` can change mask | |||
| x[1] = mxp.asarray(30, mask=False) | |||
| assert x[1].data == 30 | |||
| assert x[1].mask == False | |||
| assert not x[1].mask # mask == array(False) | |||
There was a problem hiding this comment.
was this change part of the auto-fixing of lints? I think we only need one of the two versions.
There was a problem hiding this comment.
yeah, this is https://docs.astral.sh/ruff/rules/true-false-comparison/
| python -m pip install --no-deps -e . | ||
| - uses: prefix-dev/[email protected] | ||
| with: | ||
| pixi-version: v0.39.4 |
There was a problem hiding this comment.
is there a way to automatically update this (like, using dependabot or something similar)? Otherwise I think we will only upgrade whenever one of us remembers to manually do so, which will be pretty infrequent.
There was a problem hiding this comment.
I'm not sure, let me ask
Yeah, let's. |
Co-authored-by: Justus Magin <[email protected]>
Sounds good to me! I had never used a task-runner before using pixi, but it is extremely convenient. And it is so nice to not have to worry about pip or conda environments anymore! |
This reverts parts of commit aee82ac.
|
for the CI failures, you have to run |
|
can you do that for me, please? I'll have to look into setting up |
|
sure thing when you find the time, setup is basically just |
basically just showing off pixi! Also adds pre-commit to CI