Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): specify sideEffects false #68

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

nicholaschiang
Copy link
Contributor

This package doesn't have any side effects and thus can specify
sideEffects: false in its package.json file to tell code bundlers to
exclude it from the client-side bundle when it is found in, for example,
Remix routes

This package doesn't have any side effects and thus can specify
`sideEffects: false` in its `package.json` file to tell code bundlers to
exclude it from the client-side bundle when it is found in, for example,
[Remix routes](https://remix.run/docs/en/v1/pages/gotchas#server-code-in-client-bundles)
@nicholaschiang
Copy link
Contributor Author

@mdevils

@mdevils
Copy link
Owner

mdevils commented Mar 16, 2022

Hello @nicholaschiang.
Thanks, merging.

@mdevils mdevils merged commit 3dc68bf into mdevils:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants