gherkin syntax changes and steps rework#2
gherkin syntax changes and steps rework#2mdelapenya merged 2 commits intomdelapenya:124-ingest-managementfrom EricDavisX:patch-3
Conversation
|
@mdelapenya thanks so much for helping getting us started - I hope the edits here are in line what what you are understanding from our chat in your pr. I am happy to re-work this more with you based on your feedback. |
| When the agent is re-enrolled from the host | ||
| And the agent runs from the host | ||
| Then the agent shows up in Kibana | ||
| And the agent is un-enrolled and stopped on the host |
There was a problem hiding this comment.
Wdyt about splitting this into two? So we can reuse the "stopped on the host" step
|
@mdelapenya thanks again for the discuss - I pushed the changes up as I understood them, you want to run with it come Monday and merge if you like? |
| And the agent shows up in Kibana | ||
| Scenario: Deploying an agent | ||
| Given the "Fleet" Kibana setup has been executed | ||
| And an agent is deployed to Fleet |
There was a problem hiding this comment.
How would you see this as a When? I see it as the main action in this test
| Scenario: Deploying an agent | ||
| Given the "Fleet" Kibana setup has been executed | ||
| And an agent is deployed to Fleet | ||
| When the agent is listed in Fleet as online |
There was a problem hiding this comment.
Therefore, this would be an And, and the below would be Ands
|
Hey @EricDavisX, I'm gonna merge this one into the branch, and apply indentation and above review. Great job with the steps! |
|
excellent - thanks for the super quick support and iterating on this with us |
2 participants
Hi - here are the specific changes I was thinking of. They should allow more re-use of the feature level commands, but I know we can always copy / paste some amount of code and abstract items on the implementation files.
For instance, it makes sense to me to have the explicit host-side steps broken down to:
Those can be the building blocks for all the actions done on the host side, and those in combination with the the Kibana API calls should represent what customer usage will be.