part 1 of latest EIP-4844 fee market updates #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
looks like there are new fee market updates that makes some of this out of date. please hold off on reviewing until I address them. |
roberto-bayardo
force-pushed
the
fee-market-update
branch
2 times, most recently
from
8ff6194 to
7dd8602
Compare
Collaborator
Author
|
ok changed this to simply add in the new tx field, will do the rest in follow up PRs. |
Collaborator
Author
|
ping! |
Collaborator
|
taking a look |
Inphi
approved these changes
Oct 6, 2022
interfaces.go
Outdated
Collaborator
There was a problem hiding this comment.
nit: comment should be max_fee_per_data_gas
…latest eip-4844 fee market updates
roberto-bayardo
force-pushed
the
fee-market-update
branch
from
7dd8602 to
581a83c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of implementing ethereum/EIPs#5707
This is a minimal change that gets prysm tests to pass with the corresponding prysm client update.