Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie 8 compatibility, replace indexOf method #46

Merged
merged 1 commit into from
Oct 30, 2013
Merged

ie 8 compatibility, replace indexOf method #46

merged 1 commit into from
Oct 30, 2013

Conversation

hueitan
Copy link
Contributor

@hueitan hueitan commented Oct 30, 2013

No description provided.

timschlechter added a commit that referenced this pull request Oct 30, 2013
ie 8 compatibility, replace indexOf method
@timschlechter timschlechter merged commit cf0b5e6 into mdbootstrap:master Oct 30, 2013
@timschlechter
Copy link
Contributor

Thanks!

@hueitan hueitan deleted the patch-1 branch October 30, 2013 17:17
@aolee
Copy link

aolee commented Feb 4, 2014

The fix in this commit for src/bootstrap-tagsinput.js on line 278 is still not working in IE8,

return ($.inArray(this.query.trim().toLowerCase(), text.toLowerCase()) !== -1);
or
return (text.toLowerCase().indexOf(this.query.trim().toLowerCase()) !== -1);

change it to this

var regex = new RegExp( '(' + $.trim(this.query) + ')', 'gi' );
return regex.test(text);

@PedroGabriel
Copy link

Hm
ie 8 compatibility, replace indexOf method
ie 8 compatibility? it does not work in here because of 'this' keyword... Is it normal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants