-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google SignIn & Firebase Auth not working anymore after updating #46
Comments
I did an update of all the packages on a the branch update_dependencies but haven't done sufficient testing to merge it with master. If you have a chance, can you check it out and let me know if it works for you on your end? Thanks |
There are too many bugs and errors on the first run (with fresh database, fresh account and fresh installation with clean cache). Also I think you shoud modularize and encapsulate some classes and methods and maybe change some variables name. Like a big revision. This is important, specially if you are using it as a portfolio for your curriculum and now flutter is getting bigger and there will be more people using yor project to learn. I'll try to make pull request every error that I find and fix. Some are easy, you just need to assert that some variables are not null. |
Something like that on main.dart: A little explaining:
But in my opinion Firebase functions should be encapsulated and use a interface. |
Thank you I appreciate the feedback and help. I'm currently in the middle of exams so I will not be able to work on this until the summer, at which I will at a minimum fix these bugs + explore doing a full revision. |
@GustavoContreiras could you please provide your User.dart file? I would like to update my version with your improvements. Would appreciate it! Thanks |
@kamami I don't recommend copy and paste, but you can try. user.dart:
main.dart:
|
@GustavoContreiras Thanks but there are too many other files missing. Nevermind, I will stick to the repository. |
Thats because thats for my own project. I'm using a circle_wave_progress package for a custom CircularProgressIndicator and maybe other dependencies version (check here #48). Later I'll try to make a fresh download from the repository and make a clean pull request with these changes in case anybody want to do that. Edit: example: |
@GustavoContreiras that would be really cool if you could provide your changes here! They seem like a good improvement and I would love to try them out! Thanks |
@kamami did you checkout the branch with the updated dependencies? |
@mdanics I tried it yesterday evening and the auth works fine with the updated main file! |
After updating flutter and some packages the Google SignIn is not working anymore. It seems that the package changed its procedure with the newest version.
https://pub.dartlang.org/packages/firebase_auth/versions/0.8.4+2
flutter/flutter#27133
Should not be too difficult too update the code.
Thank you and btw great project and good job!
The text was updated successfully, but these errors were encountered: