Add tests for scripts/imgtool #1983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I52646f5f27d47e3639368c6adcaa9df62b1b7853
Add missing copyright notice to clarify authorship of the original contribution. Having the notice present will make contributions to the file from other parties easier. The date of the original contribution is derived from the git history. Change-Id: I9c97f064ee8c308333058113430176b87b81b397 Signed-off-by: David Vincze <[email protected]> Signed-off-by: Rustam Ismayilov <[email protected]>
Refactor test_keys.py Move constants to separate file Verify key type in all testcases Add tests for generating keys with password Add more testcases for getpriv command Add more testcases for getpub command Add more testcases for getpubhash command Update list of expected to fail tests Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: If48a1c1496aced2e6f69f317f200aafc08d55538
Key type checking moved to separate function and added support for ed25519, enckey is enforced to be a public key Invalid pass-phrase was not reachable in methods as in that case an exception raised instead of returning "None". load_key function improved by adding handling for invalid pass-phrase and FileNotFound exception. Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I0caa0a6100fc95c8339403e991d6de0337c7a725
Add tests for various features of sign command Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I46005bbbfa3b707076f5f69e49b7e2028e13af16
Tests for verify command with various types of signed image files Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I309aa42a77812cae41007c70b99f28e2597840cf
Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I380e2839ae14ceca706e5b03f5ecf2d4ed53af5c
Added tests for verification of hex files Extract common assertions to a separate function Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: Ia20fcbec81c0fea22f7cfe4af7a8927a6dbbbc74
Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I37b54000955f30f87aff8f23a1ea71804bf967cd
Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I67e614811c31e786efebc05b9264611d6bb17edb
Move tests from imgtool/keys to test/keys Move pre-generated files to test/assets folder Fix paths for tests to run from root directory Replace hardcoded paths with constants in tests Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I100e65609f31cefa1c17f20143bceb165862fa14
d3zd3z
requested review from
utzig and
davidvincze
and removed request for
utzig and
davidvincze
|
Please also update the |
Update requirements.txt to fix failing CI jobs due to missing PrivateKeyType and PublicKeyType which are available in cryptography library since version 40.0.0 Signed-off-by: Rustam Ismayilov <[email protected]> Change-Id: I63552966051a19dc33d5c53b499d216bcfdcf89b
mingulov
reviewed
Jul 8, 2024
| @@ -1,3 +1,6 @@ | |||
| # Copyright 2024 Denis Mingulov | |||
There was a problem hiding this comment.
I am agree to add the missing copyright notice on my behalf.
There was a problem hiding this comment.
Thank you for confirming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various tests and improvements for imgtool commands