bootutil/crypto: Fix x25519 not compiling with mbedTLS #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found on Zephyr wwhile trying to compile EDCSA25519 support with -DCONFIG_BOOT_ED25519_MBEDTLS=y, where compilation eneded up in errors. It also seems that configuration has been dead for longer since the CMakeLists.txt has been needed to disable TinyCrypt source when mbedTLS is selected for ED25519. Signed-off-by: Dominik Ermel <[email protected]>
|
It seems to break Espressif that uses the internal module, different fix is needed for that. Heh.. this PR breaks TinyCrypt... seems that |
|
The CMake changes looks fine, I don't understand why you would need to remove the usages of |
|
The ASN stuff got fixed here: #1989 |
nvlsianpu
reviewed
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found on Zephyr wwhile trying to compile EDCSA25519 support with -DCONFIG_BOOT_ED25519_MBEDTLS=y, where compilation eneded up in errors.
It also seems that configuration has been dead for longer since the CMakeLists.txt has been needed to disable TinyCrypt source when mbedTLS is selected for ED25519.
This is addition to #1937, which addresses p256