Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle next call debouncing #2

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

guybedford
Copy link
Contributor

This adds the functionality to ensure that the iterator is never called multiple times while the last iteration is still completing.

As discussed in #1.

@mcollina mcollina merged commit 27ef8f5 into mcollina:master Apr 15, 2019
@mcollina
Copy link
Owner

@guybedford do you think we should get this into core?

@guybedford
Copy link
Contributor Author

I definitely think toReadable belongs in core if it is not already? Documenting the async workflows with these helpers using examples at the top of the streams docs would have saved me a lot of time personally.

@mcollina
Copy link
Owner

Would you like to send a PR to core? Maybe we can even call this Readable.from().

@guybedford
Copy link
Contributor Author

I finally managed to put together a PR here in nodejs/node#27660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants