-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject. #351
Conversation
Nice!👍 |
you forgot the [build-system] table! |
Is it necessary (there are no build dependencies)? |
Aw poop, yes it i, from https://packaging.python.org/en/latest/guides/writing-pyproject-toml/
I'll add one now. |
Added here: 9ca4e0b |
Awesome! Yeah, there is a build dependency: Since setuptools is pretty slow and has a lot of lagacy features that few people need, many pure-python projects benefit from switching to a faster build backend. But of course setuptools works fine, so no need to change anything if it works for you. |
Thanks @flying-sheep - I am thankful that you are looking out for the project. I find it super exciting how Python is modularizing/standardizing its packaging eco-system. It's funny how pip agreed to build the package without a build-system specified... whence how this went under my radar. |
The default is [build-system]
requires = ['setuptools']
build-backend = 'setuptools.build_meta:__legacy__' which behaves as closely as possible like doing But explicitly selecting a non-legacy backend works for almost all packages and executes much less hacky code. |
This fixes #350 (and removes setuptools as a dependency for installation).