fix(ci): add --fail-on-errors to danger ci command#132
Merged
Conversation
Without this flag, `danger ci` exits 0 even when it finds rule violations. This caused the "Danger PR Validation" check run to pass while the "Danger" status context showed failures, allowing PRs to merge despite failing rules. Adding --fail-on-errors ensures the workflow fails when Danger finds issues, making the check run status match the actual validation results. Fixes #131 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
martincjarvis
approved these changes
Jan 16, 2026
Collaborator
martincjarvis
left a comment
martincjarvis
left a comment
There was a problem hiding this comment.
LGTM - simple one-line fix that makes the Danger check actually block merges when it finds failures.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fail-on-errorsflag todanger cicommand in workflowProblem
Two separate checks were created:
This allowed PR #130 to merge despite Danger showing failures.
Fix
Now the workflow will fail when Danger finds issues, blocking the merge.
Closes: #131
Test Plan
🤖 Generated with Claude Code