Upgrade to netstandard2.0 instead of netcore and full .net framework. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: dropping support for 4.5 because it has gone out of support
|
@mcintyre321 It seems that building against net6.0 (unit tests) is not yet supported by the AppVeyor build task. Tests are running fine locally on my machine. Is there any way to resolve this? |
Breaking change: dropping support for 4.5 because it has gone out of support
…m/TeamSalvador/JsonDiffPatch into feature/upgrade-target-frameworks
|
I fear this PR will neither be updated to pass CI, nor that the CI will be fixed for the PR to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targetting netstandard1.x is not recommended by Microsoft anymore, as it is no longer maintained.
Microsoft now recommends to target netstandard2.0 if compatibility with .NET Framework is required.
https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/#:~:text=Use%20netstandard2.0%20to%20share%20code%20between%20.NET%20Framework%20and%20all%20other%20platforms.
The impact is low, as only support for .NET Framework 4.5.x will be dropped
Breaking change:
By updating to netstandard, net4.5 will no longer be supported.