Skip to content

Commit

Permalink
Update go to 1.21 (#20)
Browse files Browse the repository at this point in the history
* Update go to 1.21

* Update golangci-lint v
  • Loading branch information
mcbattirola committed Feb 6, 2024
1 parent 1423e4b commit 50ed3c3
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18.4"
go-version: "1.21.6"
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.46.2
version: v1.55.2
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:

- uses: actions/setup-go@v2
with:
go-version: "1.18.4"
go-version: "1.21.6"

- name: build
run: make build
- name: test
run: make test-integration
run: make test-integration
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ fmt:

# install gitnotes into /usr/local/bin
# needs sudo
# TODO: consider adding this to `install`:
# ssh-keyscan -t rsa github.com > ~/.ssh/known_hosts
# ssh-keyscan -t ecdsa github.com >> ~/.ssh/known_hosts
# (may not be necessary anymore after https://github.com/go-git/go-git/issues/411 is closed)
.PHONY: install
install: ./dist/gn
sudo cp ./dist/gn /usr/local/bin/gn
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/mcbattirola/gitnotes

go 1.18
go 1.21

require (
github.com/go-git/go-git/v5 v5.5.2
Expand Down
2 changes: 1 addition & 1 deletion pkg/gn/gn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func TestFindProject(t *testing.T) {
// assert that find project works from a inner directory
err = os.Chdir("./test")
assert.NoError(t, err)

gn.Project = "test_project"
p, err = gn.findProject()
assert.NoError(t, err)
Expand Down

0 comments on commit 50ed3c3

Please sign in to comment.