Windows fix + use autoload-dev if in dev #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallids
commented
Nov 13, 2018
hallids
commented
- fixed not working on windows but normalising directory separator
- made it use autoload-dev if in dev environment
- made it use autoload-dev if in dev environment
|
Apologies I haven't read the contributing notes. I'll resubmit as separate changes. |
|
I honestly forgot I had those notes. Thanks for this fix. |
mcaskill
added a commit
that referenced
this pull request
Dec 18, 2018
Changed: - Rename `$relativePath` to `$resolvedPath` in method `filterAutoloads()` - Method `filterAutoloads()` to normalize the resolved autoload file paths - Method `parseAutoloads()` to normalize the "vendor-dir" path - Method `parseExcludedFiles()` to normalize the the excluded file paths Fixed: - Closes #2 - Closes #3 - Closes #4 - Closes #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.