Fix activeLinks, when the url is not index #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A route can be, /accounting/generals/#/ticket", then It won't be recognized by activeLinks. But with this three lines, it will work.
|
@lokcito very nice catch! Anyway.. Sorry to not have a proper contribution guideline but you should use at least http://editorconfig.org/ to avoid mixing spaces and tabs and honor the project policy regarding code style through Also for mobile angular ui, as a bare minimum before to send a PR you should run Then, before the PR is accepted it is required to "not let the coverage decrease".. it means that if you introduced a new behaviour you should write a test for it. Rarely I receive contribution with tests, so I can write them as well, but please fix the spacing and linting. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A route can be, /accounting/generals/#/ticket", then It won't be recognized by activeLinks.
But with this three lines, it will work.
It happens, because I'm trying mobile-angular-ui in desktop browser.