-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarQube 10.4 compatibility fixes #873
Conversation
ef21b06
to
d496003
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
The new version is now 10.4.1.88267 |
Myself and my team are looking forward to this PR as well! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Looks like the release note contains only a fix about database connections issues (https://community.sonarsource.com/t/sonarqube-10-4-1-released/109966) Plugin built for 10.4.0 should be compatible with 10.4.1 Generally speaking, SQ patch releases only contains fixes, ie. does not introduce any breaking changes. |
For the impatients (so you can test out your upgrade for example), you can download the SNAPSHOT version directly from this PR: https://github.com/mc1arke/sonarqube-community-branch-plugin/actions/runs/7917642518/artifacts/1273134084 |
Updates to the latest Sonarqube minor version, including changes to the Github decorator to handle changes in the JTW library method signatures inherited from Sonarqube core, and test only changes to the Class Loader code built into Sonarqube.
Merged, thanks for the contribution! |
When installed into SonarQube 10.4, community-branch-plugin fails with
That seems to be a binary compatibility issue - the method
io.jsonwebtoken.JwtBuilder.setExpiration
is still available to the code (inherited from theio.jsonwebtoken.ClaimsMutator
), however, it used to be explicitly overridden in theio.jsonwebtoken.JwtBuilder
and now it's not.Simply rebuilding the project against SonarQube 10.4 was enough to make it work - I'm able to get PR annotations with the rebuilt plugin.
This PR also tackles a few deprecations caused by JJwt 0.11.x -> 0.12.x upgrade in SonarQube 10.4. There are, however, more deprecations in the SonarQube API that are not required yet for the plugin to work.
Fixes #870