Feature: #135 #96 comments filter and limit #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented a filter system with 3 filters (maxamount,severy,type) added commentfilter to the githubpullrequest decorator fixed the tests I broke with adding the filter added test to verify the filter is called for the Github Graphql wrote test for IssueFilterRunner. Added test for TypeExclusionFilter and SeverityExclusionFilter Added tests for TypeComparator Added tests for SeverityComparator Added default comparators for IssueFilterRunner for real build.
PiekJ
force-pushed
the
feature/135-96-comments-filter-and-limit
branch
from
4b2dd80
to
980e861
Compare
|
Removed PR #214 dependency so it can be reviewed independently. Squashed the commits too. |
|
Would be great if this one could be merged quickly. Can certainly be annoying in larger projects / projects with lots of large merge requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality for decorator comments to filter by severity, type and limit the amount of comments. This PR fixes issue #135 and #96. This PR depends on PR #214.