Skip to content

Remove use of blank method in filtering #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mburumaxwell merged 1 commit into from
Feb 27, 2023
Merged

Remove use of blank method in filtering #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions updater/bin/update-script.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,14 +305,14 @@ def security_advisories_for(dep)
safe_versions = (adv["patched-versions"] || []) +
(adv["unaffected-versions"] || [])

# Filter out nil (blank objects) and empty strings which is necessary for situations
# Filter out nil (using .compact), white spaces and empty strings which is necessary for situations
# where the API response contains null that is converted to nil, or it is an empty
# string. For example, npm package named faker does not have patched version as of 2023-01-16
# See: https://github.com/advisories/GHSA-5w9c-rv96-fr7g for npm package
# This ideally fixes
# https://github.com/tinglesoftware/dependabot-azure-devops/issues/453#issuecomment-1383587644
vulnerable_versions = vulnerable_versions.reject(&:blank?).reject(&:empty?)
safe_versions = safe_versions.reject(&:blank?).reject(&:empty?)
vulnerable_versions = vulnerable_versions.compact.reject { |v| v.strip.empty? }
safe_versions = safe_versions.compact.reject { |v| v.strip.empty? }
next if vulnerable_versions.empty? && safe_versions.empty?

Dependabot::SecurityAdvisory.new(
Expand Down