refactor:test(ex/conn_case): split conn creation into helper function
#2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/update/phoenix/conn-case-fn
branch
from
b487760 to
714708f
Compare
firestack
force-pushed
the
kf/update/phoenix/conn-case-fn
branch
from
714708f to
aedba9a
Compare
This was referenced Oct 22, 2024
firestack
force-pushed
the
kf/update/phoenix/conn-case-fn
branch
2 times, most recently
from
9dbd5d3 to
dcbd7ac
Compare
firestack
force-pushed
the
kf/update/phoenix/conn-case-fn
branch
from
dcbd7ac to
86109ea
Compare
There was a problem hiding this comment.
I'm not sure that I find this easier to read than previously, but I'm not opposed to it if you find it easier to use.
For me, I mildly prefer the single user / resource creation so that it didn't need to be a reusable function.
However, one thing I don't understand about the old file, and which you fix in your changes, is the second User.upsert(username, email) that happens for each case in the cond do. That does seem unneeded given the user = User.upsert(username, email) that happens previously.
|
Rethinking this based on the functions inserted into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on upgrading some of Skate to latest Phoenix for a personal project, and ended up refactoring
ConnCaseto see if I could make it any cleaner. I liked this, but it's not necessary, let me know what you think!