[WIP] feat(eslint): no-restricted-exports #2603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/feat/no-default-exports
branch
from
3d6638f to
cddc653
Compare
|
Unsure of whether this will work, but maybe this? https://eslint.org/docs/latest/use/configure/configuration-files#excluding-files-with-ignores |
joshlarson
force-pushed
the
kf/feat/no-default-exports
branch
from
cddc653 to
523254a
Compare
This was referenced Aug 27, 2024
firestack
force-pushed
the
kf/feat/no-default-exports
branch
from
523254a to
5a60be7
Compare
firestack
added a commit
that referenced
this pull request
Oct 11, 2024
firestack
added a commit
that referenced
this pull request
Oct 11, 2024
* fix(ts/helpers/vehicleLabel): explicitly export `vehicleLabel` * refactor: use `vehicleLabel` in `mapMarkers` * refactor: remove default export `vehicleLabel` Part of: - #2603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default exports have many downsides, from requiring the user to give it a name to only being able to have a single default export. I'd like to formally propose and lint that we don't use default exports.
This unfortunately can't be merged at this moment without fixing all of our existing default usages, or marking them all as allowed for now.