add per-environment styling #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Nov 27, 2024
| @@ -34,6 +34,8 @@ | |||
| <% end %> | |||
| <%= csrf_meta_tag() %> | |||
| <title>Screenplay</title> | |||
| <link rel="icon" href={Routes.static_path(@conn, "/favicon.ico")} sizes="32x32"> | |||
| <link rel="icon" href={Routes.static_path(@conn, "/images/favicon-#{@environment_name || "prod"}.svg")} type="image/svg+xml"> | |||
There was a problem hiding this comment.
I'm not certain if it's just a local bug for me, but my browser can't seem to load the prod favicon when running the branch. Dev and dev-green work though
There was a problem hiding this comment.
Yeah nevermind, maybe a weird caching thing or something? Works now after directly loading the path to the favicon once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: Indicator to distinguish Screenplay environment
This adds custom colors and favicons based on the configured
ENVIRONMENT_NAME. The SVG favicons should work in modern browsers, and older browsers will fall back to the ico file (which I also updated). Also converts the CSS file to use modules.