chore: OFM Reminders Job Processing Change #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
approved these changes
Nov 14, 2024
Will probably need to hardcode the webhook URL temporarily and allow the job to run on dev-green. Should be easy though. |
cmaddox5
force-pushed
the
cm/ofm-takeover-tool-reminders-fix
branch
from
9f28a6f to
31fc5e0
Compare
cmaddox5
force-pushed
the
cm/ofm-takeover-tool-reminders-fix
branch
from
afa6657 to
65ce6a2
Compare
|
Was able to successfully send a message to #tid-oio. Should be good to merge after CI is good. |
cmaddox5
force-pushed
the
cm/ofm-takeover-tool-reminders-fix
branch
from
bedef73 to
7850ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing the webhook URL for the Slack app, I remembered this being another good candidate for Oban processing. It still runs once a minute but should only run a single time each minute now. Should prevent the reminder from going off twice when it needs to.