Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Publish Glides events to Tableau #489

Merged
merged 29 commits into from
Mar 20, 2025
Merged

FEAT: Publish Glides events to Tableau #489

merged 29 commits into from
Mar 20, 2025

Conversation

huangh
Copy link
Contributor

@huangh huangh commented Mar 18, 2025

<Asana Task>

  • publish glides trips_updated and operator_signed_in data to tableau
  • convert all datetime/times to EST in tableau job

@huangh huangh requested a review from rymarczy March 18, 2025 21:45
Copy link

LCOV of commit d70abf6 during Continuous Integration (Python) #960

Summary coverage rate:
  lines......: 67.6% (2801 of 4145 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     54|    -     0|    -      0
  src/lamp_py/tableau/jobs/glides.py                                                 |38.5%     78|    -     0|    -      0
  src/lamp_py/tableau/pipeline.py                                                    |57.1%     28|    -     0|    -      0

Copy link
Collaborator

@rymarczy rymarczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to fix.

You should be able to run the run_parquet method of these jobs locally (from dev buckets) to make sure the Tableau parquet files are getting created correctly.

Copy link

LCOV of commit 0e872c2 during Continuous Integration (Python) #961

Summary coverage rate:
  lines......: 67.8% (2810 of 4142 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     54|    -     0|    -      0
  src/lamp_py/tableau/jobs/glides.py                                                 |40.0%     75|    -     0|    -      0
  src/lamp_py/tableau/pipeline.py                                                    |57.1%     28|    -     0|    -      0

Copy link

LCOV of commit 77cbf86 during Continuous Integration (Python) #962

Summary coverage rate:
  lines......: 68.2% (2873 of 4211 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     54|    -     0|    -      0
  src/lamp_py/tableau/conversions/converter.py                                       |35.2%     71|    -     0|    -      0
  src/lamp_py/tableau/hyper.py                                                       |46.0%    124|    -     0|    -      0
  src/lamp_py/tableau/jobs/glides.py                                                 |48.6%     74|    -     0|    -      0
  src/lamp_py/tableau/pipeline.py                                                    |57.1%     28|    -     0|    -      0

@huangh huangh requested a review from rymarczy March 19, 2025 21:27
Copy link

LCOV of commit fff9794 during Continuous Integration (Python) #966

Summary coverage rate:
  lines......: 70.1% (2732 of 3900 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     54|    -     0|    -      0
  src/lamp_py/tableau/hyper.py                                                       |24.2%    124|    -     0|    -      0
  src/lamp_py/tableau/jobs/glides.py                                                 |39.7%     73|    -     0|    -      0
  src/lamp_py/tableau/pipeline.py                                                    |57.1%     28|    -     0|    -      0

Copy link
Collaborator

@rymarczy rymarczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@huangh huangh merged commit 84a9259 into main Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants