FEAT: Improve memory usage of ingestion app - add new devgreen sources to ingest #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified yield_check to yield at max total nbytes of table rather than a number of rows. added config argument to pass through multi-process flag and configuration flags
…30gb. but i'm no expert. going down to 1 to test
…ld on sum instead of concat
… let the Pool default to num_cpu()
…led via poetry - only pip. WIP
…ich is unnecessary - only to save pq file size
…process spawned per gtfs-rt converter type
…S_VEHICLE_POSITIONS max out at 30%
huangh
commented
Mar 13, 2025
src/lamp_py/ingestion/ingest_gtfs.py
Outdated
|
|
||
| if config["multiprocessing"]: | ||
|
|
||
| with get_context("spawn").Pool(processes=4, maxtasksperchild=1) as pool: |
There was a problem hiding this comment.
this needs to be set to ncpu, which for our containers is 4
…e if rowgroups is causing issues
…pdating yield size to 128mb
…rocess logger around anymore
…discovered memory leak in pyarrow - apache/arrow#39808
…ta to encurage gc instead..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task