chore: Upgrade to LiveView 1.0 #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
requested review from
a team and
dks-mbta
and removed request for
a team
meagharty
approved these changes
Dec 20, 2024
| @@ -79,7 +79,7 @@ defmodule ArrowWeb.CoreComponents do | |||
| </button> | |||
| </div> | |||
| <div id={"#{@id}-content"}> | |||
| <%= render_slot(@inner_block) %> | |||
| {render_slot(@inner_block)} | |||
There was a problem hiding this comment.
I'm excited about the switch from <%= %> to { }!
dks-mbta
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: [extra] Update LiveView to 1.0
live_view_selectandsentryalso needed to be upgraded. Code changes were made following this migration guide.Reviewer Checklist