Players finishing improvements

doc/export_data_format.txt

@@ -64,13 +64,13 @@ focusing on shortest data length. All pointers in header are offsets from the
     |---|---|---|---|---|---|---|---|
  1. | 0 | T | T | T | T | T | T | T |  # bit.7 not set for pattern data
     |---|---|---|---|---|---|---|---|
- 2. | V | P |   | S | S | S | S | S |
-    |---|---|---|---|---|---|---|---|
- 3. | C | C | C | C | O | O | O | O |
+ 2. | V | P | N | S | S | S | S | S |
     |---|---|---|---|---|---|---|---|
 ...
     |---|---|---|---|---|---|---|---|
-(4) | L | L | L | L | R | R | R | R |
+(3) | C | C | C | C | O | O | O | O |
+    |---|---|---|---|---|---|---|---|
+(4) | R | R | R | R | L | L | L | L |
     |---|---|---|---|---|---|---|---|
 (5) | D | D | D | D | D | D | D | D |
     |---|---|---|---|---|---|---|---|
@@ -88,6 +88,9 @@ S - sample number:
     [0] - no change
     [1 - 31] - samples (1 - V)
 
+N - no changing sample/ornament/command:
+    [1] - nothing more than note was changed (S = 0)
+
 O - ornament number:
     [0] - no change
     [1 - 15] - ornaments (1 - F)

src/compiler/optimizer.ts

@@ -47,11 +47,16 @@ export class CompilerOptimizer {
     return this.patList.reduce<Set<number>>(
       (set, patData) => {
         for (let i = 0; i < patData.length; i++) {
-          const v = patData[i];
-          if ((v & 0x80) > 0) {
+          const t = patData[i];
+          if ((t & 0x80) > 0) {
+            // omit empty lines
             continue;
           }
           let s = patData[++i];
+          if ((s & 0x20) > 0) {
+            // omit only tone changes
+            continue;
+          }
           let o = patData[++i];
           if ((s & 0x80) > 0) {
             i++;
@@ -208,11 +213,16 @@ export class CompilerOptimizer {
   private replaceSampleInPatterns(oldSmpNum: number, newSmpNum: number) {
     this.patList?.forEach(patData => {
       for (let i = 0; i < patData.length; i++) {
-        const v = patData[i];
-        if ((v & 0x80) > 0) {
+        const t = patData[i];
+        if ((t & 0x80) > 0) {
+          // omit empty lines
           continue;
         }
         const s = patData[++i];
+        if ((s & 0x20) > 0) {
+          // omit only tone changes
+          continue;
+        }
         const si = i;
         const o = patData[++i];
         if ((s & 0x80) > 0) {
@@ -238,11 +248,16 @@ export class CompilerOptimizer {
   private renumberSamplesInPatterns(smpNum: number): void {
     this.patList?.forEach(patData => {
       for (let i = 0; i < patData.length; i++) {
-        const v = patData[i];
-        if ((v & 0x80) > 0) {
+        const t = patData[i];
+        if ((t & 0x80) > 0) {
+          // omit empty lines
           continue;
         }
         const s = patData[++i];
+        if ((s & 0x20) > 0) {
+          // omit only tone changes
+          continue;
+        }
         const si = i;
         const o = patData[++i];
         if ((s & 0x80) > 0) {
@@ -377,11 +392,16 @@ export class CompilerOptimizer {
   private replaceOrnamentInPatterns(oldOrnNum: number, newOrnNum: number): void {
     this.patList?.forEach(patData => {
       for (let i = 0; i < patData.length; i++) {
-        const v = patData[i];
-        if ((v & 0x80) > 0) {
+        const t = patData[i];
+        if ((t & 0x80) > 0) {
+          // omit empty lines
           continue;
         }
         const s = patData[++i];
+        if ((s & 0x20) > 0) {
+          // omit only tone changes
+          continue;
+        }
         const o = patData[++i];
         const oi = i;
         if ((s & 0x80) > 0) {
@@ -407,11 +427,16 @@ export class CompilerOptimizer {
   private renumberOrnamentsInPatterns(ornNum: number): void {
     this.patList?.forEach(patData => {
       for (let i = 0; i < patData.length; i++) {
-        const v = patData[i];
-        if ((v & 0x80) > 0) {
+        const t = patData[i];
+        if ((t & 0x80) > 0) {
+          // omit empty lines
           continue;
         }
         const s = patData[++i];
+        if ((s & 0x20) > 0) {
+          // omit only tone changes
+          continue;
+        }
         const o = patData[++i];
         const oi = i;
         if ((s & 0x80) > 0) {

src/compiler/renderer.ts

@@ -310,20 +310,27 @@ export default class CompilerRender extends CompilerOptimizer {
             else {
               lastEmptyLines = 0;
               data[offY++] = b1;
-              data[offY++] = b2;
-              data[offY++] = b3;
-              if (vol > 0) {
-                data[offY++] = vol;
-              }
-              if (cmd > 0) {
-                if (cmd === 0xB) { // Cmd-B
-                  const backOffset = offY - breakToLineOffset + 2;
-                  writeWordLE(data, offY, -backOffset);
-                  offY += 2;
-                  break;
+
+              if (b2 > 0 || b3 > 0) {
+                data[offY++] = b2;
+                data[offY++] = b3;
+                if (vol > 0) {
+                  data[offY++] = vol;
                 }
+                if (cmd > 0) {
+                  if (cmd === 0xB) { // Cmd-B
+                    const backOffset = offY - breakToLineOffset + 2;
+                    writeWordLE(data, offY, -backOffset);
+                    offY += 2;
+                    break;
+                  }
 
-                data[offY++] = dat;
+                  data[offY++] = dat;
+                }
+              }
+              else {
+                // optimization for only note changed
+                data[offY++] = 0x20;
               }
             }
           }