Skip to content

Commit

Permalink
Merge pull request #153 from dwapstra/tag_num_without_tag
Browse files Browse the repository at this point in the history
Check for non-final tag if --tag-num specified
  • Loading branch information
mbarkhau authored Jan 17, 2021
2 parents 6d727ad + a73ab98 commit b337765
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,7 @@ fabric.properties
.idea/httpRequests

# Android studio 3.1+ serialized cache file
.idea/caches/build_file_checksums.ser
.idea/caches/build_file_checksums.ser

# Visual Studio Code
.vscode
5 changes: 5 additions & 0 deletions src/bumpver/v2version.py
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,11 @@ def incr(
else:
cur_vinfo = old_vinfo._replace(**cur_cinfo._asdict())

has_tag_part = cur_vinfo.tag != "final"
if tag_num and not tag and not has_tag_part:
logger.error("Invalid arguments, non-final --tag=<tag> is needed to use --tag-num.")
return None

cur_vinfo = _incr_numeric(
raw_pattern,
old_vinfo,
Expand Down
12 changes: 12 additions & 0 deletions test/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ def test_bump_random(monkeypatch):
cur_version = new_version


def test_bump_tag_num():
raw_pattern = "MAJOR.MINOR.PATCH[PYTAGNUM]"
cur_version = "0.1.1b0"
assert v2version.incr(cur_version, raw_pattern, tag_num=True) == "0.1.1b1"


def test_bump_tag_num_without_tag():
raw_pattern = "MAJOR.MINOR.PATCH[PYTAGNUM]"
cur_version = "0.1.1"
assert v2version.incr(cur_version, raw_pattern, tag_num=True) is None


def test_parse_version_info():
version_str = "v201712.0001-alpha"
version_info = v1version.parse_version_info(version_str)
Expand Down

0 comments on commit b337765

Please sign in to comment.