Bug/allow header to contain http verb keys axios#1252 (axios#1258)

* Failing test for axios#1252 * Only delete header keys that match an HTTP verb if the value is a non-string Co-authored-by: David Ko <[email protected]> Co-authored-by: Jay <[email protected]>
mbargiel · May 22, 2020 · 920510b · 920510b
1 parent 1cdf9e4
commit 920510b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/core/dispatchRequest.js b/lib/core/dispatchRequest.js
@@ -43,7 +43,9 @@ module.exports = function dispatchRequest(config) {
   utils.forEach(
     ['delete', 'get', 'head', 'post', 'put', 'patch', 'common'],
     function cleanHeaderConfig(method) {
-      delete config.headers[method];
+      if (typeof config.headers[method] !== 'string') {
+        delete config.headers[method];
+      }
     }
   );
 

diff --git a/test/specs/headers.spec.js b/test/specs/headers.spec.js
@@ -86,4 +86,17 @@ describe('headers', function () {
       done();
     });
   });
+
+  describe('when a header key matches an HTTP verb', function() {
+    it('preserves the header value', function(done) {
+      axios.post('/foo', null, { 'headers': { 'delete': 'test' } });
+
+      getAjaxRequest().then(function (request) {
+        var headerValue = request.requestHeaders['delete'];
+
+        expect(headerValue).toEqual('test');
+        done();
+      });
+    });
+  });
 });