-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LeakyBuildingPit element #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add LeakyIntHeadDiffEquation mixin class - add LeakyIntHeadDiffLineSink element for leaky pit boundaries with leaky walls - add LeakyBuildingPit element, inherits from BuildingPit but adds resistance term - add notebook testing LeakyBuildingPit allow BuildingPit to be placed in models with 1 layer isort __init__
- add disvecnorm: calculate disvec normal to angle theta - intdisvecnorm: quad/legendre integration of disvecnorm - add quad integrand function for integrating from 0->r
- improve code and docstring
This was
linked to
issues
Jul 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for LeakyBuildingPit element, plus some other developments:
Add LeakyBuildingPit elements (#72):
Add integrated normal flux method to model class (#60)
ml.intnormflux()
for calculating flux flowing over a specified line.Fix bug in resistance factor calculations (#71)
resfac = T / res
byresfac = Haq / res
. Tested by comparing LeakyLineDoublet solution to exact analytical solution for circular building pit.Other changes:
__init__.py
TODO: