Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Leaky)BuildingPit does not convert layers to numpy array internally #75

Closed
Huite opened this issue Aug 25, 2023 · 0 comments
Closed

(Leaky)BuildingPit does not convert layers to numpy array internally #75

Huite opened this issue Aug 25, 2023 · 0 comments

Comments

@Huite
Copy link
Contributor

Huite commented Aug 25, 2023

Bit of a nitpick really, but I just noticed that the BuildingPit do not call np.atleast_1d(layers) while this does happen for all other elements. BuildingPit inherits from AquiferData, not Element.

I noticed since layers.size won't work in this case.
dbrakenhoff added a commit that referenced this issue Sep 10, 2023
@dbrakenhoff
fix #75
9d4edcd
dbrakenhoff added a commit that referenced this issue Sep 10, 2023
@dbrakenhoff
Merge pull request #80 from mbakker7/75-buildingpit-layers
b2cb772 
fix #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Huite