Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2039] Applied some fixes to Userfeed plugin #969

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Jan 19, 2024

  • Plugin title editable via plugin options
  • Weird warning in gettext output
  • CSS margin above plugin

@@ -1,5 +1,6 @@
.userfeed {
position: relative;
margin-top: var(--row-height);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiromaykin I added this as quickfix; please verify if we want to keep this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is alright for now since the other plugins are also using a margin and these are only used on Home - but actually...
I would need to refactor/check them all at some point, since "Margins break component encapsulation. A well-built component should not affect anything outside itself... Components shouldn't care about spacing between them. Their parents should."

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bdc8f79) 94.79% compared to head (cdecbbe) 94.79%.

Files Patch % Lines
src/open_inwoner/cms/plugins/models/userfeed.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #969      +/-   ##
===========================================
- Coverage    94.79%   94.79%   -0.01%     
===========================================
  Files          857      858       +1     
  Lines        30085    30093       +8     
===========================================
+ Hits         28519    28526       +7     
- Misses        1566     1567       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme merged commit e2465e6 into develop Jan 19, 2024
14 checks passed
@alextreme alextreme deleted the fix/2039-userfeedtweaks branch January 19, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants