✨ [#1950] Filter by vestigingsnummer in Mijn Vragen #941
Conversation
stevenbal
force-pushed
the
feature/1950-mijn-vragen-vestigingsnummer
branch
from
4e231f0
to
8020049
Compare
stevenbal
force-pushed
the
feature/1950-mijn-vragen-vestigingsnummer
branch
from
8020049
to
1b7ac8c
Compare
| params = {"subjectNietNatuurlijkPersoon__innNnpId": user_kvk_or_rsin} | ||
|
|
||
| if vestigingsnummer: | ||
| params = { |
There was a problem hiding this comment.
This code does assume that a Contactmoment that is relevant for both the hoofdvestiging and another vestiging has two KlantContactMomenten.
This also means that the UUID of the entries that show up in the listview for the hoofdvestiging and the vestiging are different (because they belong to different KlantContactMomenten that point to the same ContactMoment)
There was a problem hiding this comment.
As there's no other way to model this using the Contactmomenten API this is indeed implied (itt. the Zaken API which does allow multiple participants for a case).
We'll have to test this with Enschede & the eSuite in order to be sure this works as expected
stevenbal
force-pushed
the
feature/1950-mijn-vragen-vestigingsnummer
branch
from
1b7ac8c
to
e8c940f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
+ Coverage 93.07% 93.09% +0.02%
===========================================
Files 828 828
Lines 28949 29055 +106
===========================================
+ Hits 26943 27049 +106
Misses 2006 2006 ☔ View full report in Codecov by Sentry. |
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1950