⚗️ [#1910] Experiment for creating Heading 1 NLDS component #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
feature/1910-add-NLDS-heading
branch
from
73cbbb0
to
bb9b26b
Compare
jiromaykin
force-pushed
the
feature/1910-add-NLDS-heading
branch
from
810da45
to
fc391bd
Compare
jiromaykin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #890 +/- ##
========================================
Coverage 92.81% 92.81%
========================================
Files 803 803
Lines 27531 27536 +5
========================================
+ Hits 25553 25558 +5
Misses 1978 1978 ☔ View full report in Codecov by Sentry. |
|
This needs to be done differently :-) with an actual design-token import instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to create H1 on the basis of NL-DesignSystem Utrecht community component, like it's a layer on top of our own SCSS variables.
Issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1910