Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [#1889] Remove null=True from User CharFields #881

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

stevenbal
Copy link
Contributor

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests mogen nog wat aandacht krijgen maar prima om dit te corrigeren

@stevenbal stevenbal force-pushed the issue/1889-remove-null-from-user-charfields branch from c9d6bdb to 1bca867 Compare December 7, 2023 08:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf4458b) 92.81% compared to head (1bca867) 92.81%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #881   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files          802      803    +1     
  Lines        27525    27531    +6     
========================================
+ Hits         25547    25553    +6     
  Misses        1978     1978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but a doublecheck from @pi-sigma would be appreciated

@alextreme alextreme merged commit 59dc8af into develop Dec 7, 2023
14 checks passed
@alextreme alextreme deleted the issue/1889-remove-null-from-user-charfields branch December 7, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants