[#1839] Enable/disable notifications per status type #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #838 +/- ##
========================================
Coverage 92.84% 92.85%
========================================
Files 753 755 +2
Lines 26143 26172 +29
========================================
+ Hits 24272 24301 +29
Misses 1871 1871
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
stevenbal
requested changes
Nov 9, 2023
src/open_inwoner/openzaak/models.py
Outdated
| @@ -362,6 +362,7 @@ class ZaakTypeStatusTypeConfig(models.Model): | |||
| "Description that will be shown above the document upload widget in a case detail page" | |||
| ), | |||
| ) | |||
| notify_status_change = models.BooleanField(default=True) | |||
There was a problem hiding this comment.
Could you add a verbose_name and help_text for this field?
There was a problem hiding this comment.
This comment was resolved, but I think you forgot to add these attributes?
pi-sigma
force-pushed
the
feature/1839-notifications
branch
3 times, most recently
from
8a46eb1
to
18739a1
Compare
stevenbal
requested changes
Nov 13, 2023
src/open_inwoner/openzaak/models.py
Outdated
| @@ -362,6 +362,7 @@ class ZaakTypeStatusTypeConfig(models.Model): | |||
| "Description that will be shown above the document upload widget in a case detail page" | |||
| ), | |||
| ) | |||
| notify_status_change = models.BooleanField(default=True) | |||
There was a problem hiding this comment.
This comment was resolved, but I think you forgot to add these attributes?
|
@pi-sigma could you fix the merge conflict as well? |
pi-sigma
force-pushed
the
feature/1839-notifications
branch
from
18739a1
to
6f8e3ff
Compare
|
@stevenbal Sorry for the confusion, I must have made a mistake during rebasing. |
stevenbal
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga #1839