-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1794] Redesign case detail-page header #824
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #824 +/- ##
===========================================
+ Coverage 93.01% 93.10% +0.08%
===========================================
Files 744 748 +4
Lines 25951 25828 -123
===========================================
- Hits 24138 24046 -92
+ Misses 1813 1782 -31
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d60e7df
to
bade052
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4d767b4
to
e455d7b
Compare
I've fixed it in this PR for the Detail page only - but it should actually be simplified and homogenised in another PR for the List view after this is merged (because the sidebar is going to be removed in all Aanvragen pages), so I'll have remember that. |
e455d7b
to
c59f354
Compare
Looking good (flaky tests but seems alright now). |
Strangely enough the tests suddenly passed through this morning (after 3 days) - odd! |
@@ -14,7 +14,9 @@ | |||
} | |||
|
|||
@media (min-width: 768px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about these magic numbers as breakpoints? I see @media (min-width: 768px) {
here but in the file above there is @media (min-width: 767px) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah: min-width should be 768px everywhere, but max-width should be 767px
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1793
The newly. designed Dashboard component requires restructuring of the detail page grid + has impact on Contactmoment detail page.
Also: Anchormenu references need to be removed for Case detail
(and from Case list in other PR).
Note: unsure which variable is needed for "Verwachte uitslag" (now set to
end_date_legal
)