Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1794] Redesign case detail-page header #824

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Oct 23, 2023

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1793
The newly. designed Dashboard component requires restructuring of the detail page grid + has impact on Contactmoment detail page.
Also: Anchormenu references need to be removed for Case detail
(and from Case list in other PR).

Note: unsure which variable is needed for "Verwachte uitslag" (now set to end_date_legal)

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #824 (e455d7b) into develop (c2da1ed) will increase coverage by 0.08%.
Report is 14 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #824      +/-   ##
===========================================
+ Coverage    93.01%   93.10%   +0.08%     
===========================================
  Files          744      748       +4     
  Lines        25951    25828     -123     
===========================================
- Hits         24138    24046      -92     
+ Misses        1813     1782      -31     
Files Coverage Δ
src/open_inwoner/cms/cases/tests/test_htmx.py 20.96% <ø> (+1.27%) ⬆️
..._inwoner/components/templatetags/dashboard_tags.py 100.00% <ø> (ø)
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <ø> (ø)

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the feature/1793-redesign-case-detail-header branch 2 times, most recently from d60e7df to bade052 Compare October 24, 2023 12:39
@jiromaykin jiromaykin marked this pull request as ready for review October 24, 2023 13:13
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spinner on the detail page is no longer centered after the removal of the sidebar anchors (see screenshot). Is this something that will be fixed in a separate PR?

Screenshot from 2023-10-26 11-01-32

@jiromaykin jiromaykin force-pushed the feature/1793-redesign-case-detail-header branch 2 times, most recently from 4d767b4 to e455d7b Compare October 26, 2023 17:23
@jiromaykin
Copy link
Contributor Author

The spinner on the detail page is no longer centered after the removal of the sidebar anchors"

I've fixed it in this PR for the Detail page only - but it should actually be simplified and homogenised in another PR for the List view after this is merged (because the sidebar is going to be removed in all Aanvragen pages), so I'll have remember that.

@jiromaykin jiromaykin force-pushed the feature/1793-redesign-case-detail-header branch from e455d7b to c59f354 Compare October 27, 2023 09:44
@pi-sigma
Copy link
Contributor

Looking good (flaky tests but seems alright now).

@jiromaykin
Copy link
Contributor Author

Looking good (flaky tests but seems alright now).

Strangely enough the tests suddenly passed through this morning (after 3 days) - odd!

@@ -14,7 +14,9 @@
}

@media (min-width: 768px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about these magic numbers as breakpoints? I see @media (min-width: 768px) { here but in the file above there is @media (min-width: 767px) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah: min-width should be 768px everywhere, but max-width should be 767px

@alextreme alextreme merged commit 206893d into develop Nov 1, 2023
14 checks passed
@alextreme alextreme deleted the feature/1793-redesign-case-detail-header branch November 1, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants