[#1805] Fix xml error #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #810 +/- ##
===========================================
- Coverage 93.05% 93.04% -0.02%
===========================================
Files 742 742
Lines 25821 25825 +4
===========================================
+ Hits 24028 24029 +1
- Misses 1793 1796 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pi-sigma
force-pushed
the
fix/1805-xml-error
branch
from
2837fd6
to
60821e4
Compare
alextreme
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga #1805
The bug is caused by incorrect use of
lxml.fromstring, which returns an lxml element instead of the document tree, in contrast tolxml.parsewhich was used to read in the content of the file object during testing.