[#1763] Change texts and table for profile page #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
fix/1763-change-profile-page-after-feedback
branch
2 times, most recently
from
3010522
to
1a42694
Compare
jiromaykin
changed the title
jiromaykin
force-pushed
the
fix/1763-change-profile-page-after-feedback
branch
3 times, most recently
from
d6d7373
to
8b030a6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #790 +/- ##
===========================================
- Coverage 93.17% 93.16% -0.01%
===========================================
Files 721 722 +1
Lines 25027 25020 -7
===========================================
- Hits 23318 23311 -7
Misses 1709 1709
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jiromaykin
force-pushed
the
fix/1763-change-profile-page-after-feedback
branch
from
19d1104
to
e961641
Compare
jiromaykin
force-pushed
the
fix/1763-change-profile-page-after-feedback
branch
from
32d1ab1
to
65634bd
Compare
alextreme
reviewed
Oct 3, 2023
| {% url 'profile:contact_list' as mentor_url %} | ||
| {% link href=mentor_url|add:"?type=begeleider" text=_('My mentor(s)') %} | ||
| {% else %} | ||
| {% trans "Begeleider(s)" %} |
alextreme
approved these changes
Oct 3, 2023
pi-sigma
reviewed
Oct 3, 2023
| <div class="tabled__item">{{request.user.get_full_name}}{% if request.user.get_address %}, {{ request.user.get_address }}{% endif %}</div> | ||
| <div class="tabled__item tabled__item--force-right tabled__item--mobile-big">{% link href="profile:data" text="Bekijken" icon="arrow_forward" icon_position="after" primary=True %}</div> | ||
| </div> | ||
| {% endif %} | ||
|
|
||
| {% if view.config.selected_categories %} | ||
| <div class="tabled__row"> | ||
| <div class="tabled__item tabled__item--bold">{% trans "Interessegebieden" %}</div> | ||
| <div class="tabled__item tabled__item--bold">{% link href="profile:categories" text=_('My categories') %}</div> |
There was a problem hiding this comment.
Why English? Most of the texts in this template are in Dutch.
There was a problem hiding this comment.
I was thinking: if I have to change some text per request from one of the municipalities, or add completely new text, the default should be in English - this could be a gradual way to change all code-text into English. I can update this me.html template to be completely English.
There was a problem hiding this comment.
Good to know. Feel free to get started with this, but no pressure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue connected to feedback about texts from Leeuwarden: https://taiga.maykinmedia.nl/project/open-inwoner/task/1763
Making topics in Profile into a link.
When adding new texts: make them English by default.
More new design is coming up in new issue.
Note to myself for translations:
interessegebieden wordt 'mijn onderwerpen'; Communicatievoorkeuren wordt 'ontvang berichten over'/Receive notifications for